Payment states of the order reflect state (or status) of the payment

What is the need / problem?

The payment state of the order reflects the payment state of the payment (or payment status), when a Stripe SCA payment is added to the order: both are displayed as requires_authorization. If this payment fails then

This is confusing as the payment state of the order should rather have a "pointer" function, i.e., only indicating whether balance is due, credit is owed or the order is paid (with the respective states + none).

For a Stripe SCA payment:

For a cash payment:

It also happens for a failed payment attempt - ex. using a the card 4000000000009995:

Which type of users does this problem affect (and how many, if known)?

Hub Managers (MCFEs)

Potential solutions that will solve the problem ?[[brainstorming to list feature candidates]

Currently payment state of the order can be:

Balance due
Credit Owed
Paid
Void -> in UK-prod: SELECT COUNT(*) FROM spree_orders WHERE payment_state = 'void'; -> 306
Failed -> in UK-prod: SELECT COUNT(*) FROM spree_orders WHERE payment_state = 'failed'; -> 209
Authorization Required -> SELECT * FROM spree_orders WHERE payment_state = 'requires_authorization'; -> 0
None (empty)

The improvement would be the payment state of the order to exclusively have the "pointer" function having these as the only allowed states:

balance_due
credit_owed
paid
(none) -> when no payment is added to the order

Connected wishlist and discovery discussions* [list precedent discussions]

openfoodfoundation/wishlist#107 openfoodfoundation/openfoodnetwork#8912 openfoodfoundation/wishlist#109

Additional context

https://miro.com/app/board/o9J_lEsaK4Q=/

Is Papercut or feature candidate?

Feature candidate.

openfoodfoundation / wishlist