search

openfoodfoundation / wishlist

This repository welcomes ideas and suggestions to improve the OFN software.
3 stars 0 forks source link

Add tag field to incoming products of an order cycle #441

Open drummer83 opened 2 years ago

drummer83 commented 2 years ago

Description

- As a: hub (enterprise selling also or only product from other enterprises) or super admin - On page: step 2 of creating or editing an order cycle (incoming products) - I want to be able to do: use tags for each producer (same process than when tagging hubs on step 3)

More context

A shop manager is offering discounts to customers who already have a subscription with that shop (subscriptions are managed outside the OFN currently). Customers without subscriptions do not get any discounts. This can be achieved by applying a negative payment fee to customers tagged 'has subscription'. The shop manager now wants to include products of other suppliers in his shop, but he can't provide discounts on those products (no matter if the customer has a subscription or not). This is currently only possible by creating two order cycles and applying a negative enterprise fee on the 'incoming products' section for the corresponding supplier. Using two order cycles adds additional work when fulfilling the orders and working with reports.

If the negative enterprise fee could be tagged and applied to customers with subscriptions only, this could be done within one order cycle.

Design proposal

Add tag columns with same design than in outgoing products, in between "products" and "receival details"

How it's shown currently for outgoing products

image

Acceptance Criteria & Tests

  1. Login in as hub
  2. I can add tags on step 2 of the order cycle
  3. I can set up tags on enterprise settings, customers and shipping/payment methods
  4. The rule defined works as expected.

Run this scenario, with using the same tag on 1 producer or several. Also try the case of using the same tag for both incoming and outgoing.

RachL commented 2 years ago

A bit risky to have it as papercut. Perhaps we can add it as papercut but review if we extend the time. It's a papercut but for a senior OFN dev. also testing will be tough.

RachL commented 1 year ago

@openfoodfoundation/testers Now that JB has worked on it I don't think this is useful right now. I'm sorry I didn't catch this when reviewing the papercut.

Tags can be applied to hide/show: shipping methods, inventory variants and OC. But for a shop not a producer.

When BackOffice UI Uplift will be done, we will work on introducing tags on product variants: the plan is to slowly move to a unified catalog and get rid of inventory. With tags on product it will be useful to be able to tag producers. But right now I can't think of any case where the tag can actually apply. Do you see any?

If so, I would vote to introduce this only when tags can be done on product catalog. To avoid introducing something users won't be able to use.