search

openfootball / worldcup

Free open public domain football data for the World Cup (incl. Qatar 2022, Russia 2018, Brazil 2014, etc.) and World Cup Quali(fiers)
Creative Commons Zero v1.0 Universal
544 stars 180 forks source link

added full names to all goal scorers to fix personID assignment and fixe... #25

Closed mpodell closed 10 years ago

mpodell commented 10 years ago

...d o.g. punctuation for Kolašinac.

The (o.g) for Kolašinac is missing the period after 'g' and thus '(o.g)' to is appending Messi's name. More importantly, James Rodriguez is not getting assigned to all his goals. 'Rodriguez' is getting assigned to 'Cristian Rodriguez' of Uruguay. I updated all goal scorers to include firs/last for consistency.

geraldb commented 10 years ago

Great. Thanks. Unfortunately, GitHub says: We can’t automatically merge this pull request. Can you rework/fix the pull request if possible? (Currently it tries to replace the two files completely). If it's not possible (or as an alternative) I can add you to the team and you can change the goal lines in the browser, for example. Cheers.

mpodell commented 10 years ago

OK. I had to roll back and recommit so I'm closing this pull request and will re-request. (Not sure that is the right thing to do but I'm a newbie.)

mpodell commented 10 years ago

arg. apparently I should not have closed the request. Re-opening. But now the file should be able to be merged.

geraldb commented 10 years ago

@mpodell Thanks for retrying and your efforts. It worked. Sorry I'm also new to the push request flow/machinery. I've added you to the team - Editors (world-cup, players) - if anything comes up in the future you're welcome to change it in the repo without pull request. Welcome. Thanks again. Cheers.