search

openfootball / worldcup

Free open public domain football data for the World Cup (incl. Qatar 2022, Russia 2018, Brazil 2014, etc.) and World Cup Quali(fiers)
Creative Commons Zero v1.0 Universal
546 stars 180 forks source link

Update cup_finals.txt #45

Closed hidenobunagai closed 6 years ago

hidenobunagai commented 6 years ago

Updated with the France - Argentina match.

geraldb commented 6 years ago

@hidenobunagai Thanks again for the update and your help.

PS: Let me know if you're interested in helping to keep the world cup update-to-date you're more than welcome to join the openfootball org (if you're interested please let me now and I send you an invite for the org (via github) so you can edit /change the page "inline" without pull request etc. Cheers. Keep it up. Enjoy the beautiful game.

hidenobunagai commented 6 years ago

@geraldb Thank you. Yes, it would be appreciated if you could send me an invite and I'll do my best.

By the way, it seems that the JSON file is not updated with this. I am just wondering if I did something wrong? I cannot figure it out.

geraldb commented 6 years ago

@hidenobunagai About the JSON - nothing wrong - sorry no automation for now - I have to rebuild the SQL database "by hand" with a build script and export "by hand" and check in. For now I do it once a day in the morning. See the scripts here ->https://github.com/yorobot/football.db

Great. Welcome. Note: You will get an invitation (by email from GitHub) to join the openfootball org as a member. If you accept, you can update the worldcup pages in your browser - no longer any need for a pull request - and you will show up in the people page too (if you set your preference to public - default is private; change the setting in the github org people page).