openforcefield / openff-benchmark

Comparison benchmarks between public force fields and Open Force Field Initiative force fields
MIT License
11 stars 2 forks source link

Molecule export fails for unspecified stereochemistry #58

Closed jthorton closed 3 years ago

jthorton commented 3 years ago

When exporting molecules from a qcarchive instance we use the from_qcschema method with allow_undefined_stereo=False this is then causing the export to fail if we hit any unspecified stereochemistry cases in which some users are. As we preprocess all molecules into the pipeline these issues should not arise but from reports, this seems to be related to nitrogen stereochemistry which has a history of toolkit issues collected here https://github.com/openforcefield/openff-toolkit/issues/146.

I propose that we allow undefined stereochemistry at this point as any major issues should have been prefiltered but it would good to get your opinion @j-wags.

dotsdl commented 3 years ago

Addressed by #65. Closing!