openforcefield / openff-benchmark

Comparison benchmarks between public force fields and Open Force Field Initiative force fields

MIT License

10 stars 2 forks source link

Removed defaults for subcommands with `multiple` keyword #80

Closed dotsdl closed 3 years ago

dotsdl commented 3 years ago

This change is needed for click 8.0 compatibility. Alternatively, defaults could be wrapped in a list, but I'm hesitant to put a list as a default argument to a function (generally a bad idea).

Status

[ ] Ready to go

dotsdl commented 3 years ago

@dfhahn this mainly concerns the report subcommand tree. Are you okay with these changes? I don't believe they impact usage of the Season 1 protocol.

codecov-commenter commented 3 years ago

Codecov Report

Merging #80 (06ff926) into master (f26b615) will not change coverage. The diff coverage is 100.00%.

dotsdl commented 3 years ago

I'm going to go ahead and merge; I don't believe this is a catastrophic change.