search

openforcefield / openff-docs

Documentation for the Open Force Field ecosystem
https://docs.openforcefield.org/
MIT License
0 stars 2 forks source link

fix issue #29 #30

Closed mikemhenry closed 9 months ago

mikemhenry commented 10 months ago

Temp fix to #29, not sure if you want this or just want to wait until https://github.com/conda-incubator/condacolab/pull/63 gets merged in and a new release lands on PyPI

Yoshanuikabundi commented 10 months ago

Thanks for this Mike! We're currently relying on an older cache of the Colab notebooks until I get a chance to sort #27 out, so if we did merge this it wouldn't do anything until that's merged unfortunately... by which point condacolab may well be updated.

We could patch the cache directly (the _cookbook_data branch: https://github.com/openforcefield/openff-docs/tree/_cookbook_data/main/build/cookbook/colab/openforcefield)... let me have a think about whether that's something I want to do.

Yoshanuikabundi commented 9 months ago

I've fixed the issue by manually editing the cache. I'm going to merge this as well in case I fix the builds before this is fixed upstream. CI is failing because it doesn't work off a branch. But this change can't break anything worse than its already broken!