openforcefield / openff-evaluator

A physical property evaluation toolkit from the Open Forcefield Consortium.
https://docs.openforcefield.org/projects/evaluator
MIT License
55 stars 18 forks source link

Provide bond lengths in virtual site tests #523

Closed mattwthompson closed 1 year ago

mattwthompson commented 1 year ago

Description

The most recent version of Interchange determines virtual site positions based on geometries determined by the force field, which broke some tests. I think they previously used the atomic coordinates, which might not accurately represent the force field geometries.

codecov[bot] commented 1 year ago

Codecov Report

Merging #523 (c43797d) into main (2fd5163) will decrease coverage by 0.01%. The diff coverage is n/a.

Additional details and impacted files