openforcefield / openff-models

Helper classes for Pydantic compatibility in the OpenFF stack
MIT License
3 stars 2 forks source link

Use Pydantic v1 API from v2 #27

Closed mattwthompson closed 1 year ago

mattwthompson commented 1 year ago

Description

This is an easier attempt at #26, enabling v2 to be installed while basically keeping the code the same, using pydantic.v1.

Thanks for @jthorton for tipping us off to https://docs.pydantic.dev/latest/migration/#continue-using-pydantic-v1-features.

Todos

Notable points that this PR has either accomplished or will accomplish.

Questions

Status

codecov-commenter commented 1 year ago

Codecov Report

Merging #27 (7ab6620) into main (ff399c9) will increase coverage by 0.09%. The diff coverage is 100.00%.

Additional details and impacted files
mattwthompson commented 1 year ago

This is working much better than I expected (and I expected it to work well and work quickly) at least by the green check.

Could I get a quick pair of eyes to make sure I'm not missing anything obvious @jthorton or @hmacdope?

mattwthompson commented 1 year ago

Thanks both! Now to incrementally do the same for every other repo ... 😁