Another Pydantic v2 rewrite - Githubissues

openforcefield / openff-models

Helper classes for Pydantic compatibility in the OpenFF stack

MIT License

3 stars 2 forks source link

Another Pydantic v2 rewrite #42

Open mattwthompson opened 6 months ago

mattwthompson commented 6 months ago

Description

This is like #26 but it doesn't attempt to precisely keep the old design.

[x] Use Annotated to more directly add information to type annotations
[x] Add some convenience annotated types for commonly-used dimensions
[x] Test that mixed models don't immediately crash out of a v1/v2 incompatibility
[ ] Think about if/how to coerce squishy-but-similar types, like ensuring float are cast to int as FloatQuantity currently does
[ ] Rename quack_into_unit

Todos

Status

[ ] Ready to go

codecov-commenter commented 6 months ago

Codecov Report

Attention: Patch coverage is 68.05556% with 46 lines in your changes missing coverage. Please review.

Project coverage is 69.93%. Comparing base (afcef40) to head (bbc2416). Report is 2 commits behind head on main.

Additional details and impacted files