openforcefield / openff-qcsubmit

Automated tools for submitting molecules to QCFractal
https://openff-qcsubmit.readthedocs.io/en/latest/index.html
MIT License
26 stars 4 forks source link

Dihedral selection update #157

Closed jthorton closed 3 years ago

jthorton commented 3 years ago

Description

This PR updates the torsiondrive deduplication method to also take into account the symmetry of the molecule. Now only one torsion per unique symmetry group is stored and scanned. The coverage and smarts filters have had their ability to tag torsions removed to simplify the classes as torsion selection should now be done using the scan filters.

Example: For a molecule that has multiple torsions highlighted which are not symmetry unique the current deduplication method will result in the following dataset with 8 torsiondrives image After the deduplication update, we get the following dataset with only 6 torsiondrives as expected image

Todos

Notable points that this PR has either accomplished or will accomplish.

Status

codecov[bot] commented 3 years ago

Codecov Report

Merging #157 (61511f8) into master (7ebb798) will increase coverage by 0.11%. The diff coverage is 92.85%.