openforcefield / openff-qcsubmit

Automated tools for submitting molecules to QCFractal
https://openff-qcsubmit.readthedocs.io/en/latest/index.html
MIT License
26 stars 4 forks source link

Multi-component system update #180

Closed jthorton closed 2 years ago

jthorton commented 2 years ago

Description

This PR updates the handling of multi-component systems, these are now split and remade to ensure each component is in continuous ordering which avoids qcelemtantal validation failures which only appear during the calculation. To ensure the attributes are then consistent with the molecule they are regenerated and no longer needed when adding a molecule to a dataset. Attributes can still be passed but this is only advised when creating datasets from results to ensure they are consistent.

Status

codecov[bot] commented 2 years ago

Codecov Report

Merging #180 (a6c7ad3) into master (cc13394) will decrease coverage by 0.05%. The diff coverage is 100.00%.