openforcefield / openff-qcsubmit

Automated tools for submitting molecules to QCFractal
https://openff-qcsubmit.readthedocs.io/en/latest/index.html
MIT License
26 stars 4 forks source link

Update `get_torsion` for OpenFF Toolkit 0.12 #210

Closed mattwthompson closed 1 year ago

mattwthompson commented 1 year ago

Description

Resolves #209

The function get_torsion included in its logic some empheral Atom objects with atomic numbers of 0, which are now forbidden. I've changed the logic to avoid needing to do this. The behavior is the same as far as I understand the function to work.

I've also taken the liberty of updating some outdated bits in the test environment.

Todos

Notable points that this PR has either accomplished or will accomplish.

Status

codecov[bot] commented 1 year ago

Codecov Report

Merging #210 (464d17a) into main (7aa1982) will increase coverage by 0.00%. The diff coverage is 100.00%.

Additional details and impacted files