openforcefield / openff-qcsubmit

Automated tools for submitting molecules to QCFractal

https://openff-qcsubmit.readthedocs.io/en/latest/index.html

MIT License

26 stars 4 forks source link

Update for Black 23 #213

Closed mattwthompson closed 1 year ago

mattwthompson commented 1 year ago

Description

The context here is identical to https://github.com/openforcefield/openff-bespokefit/pull/225

black introduced its annual breaking changes late January, which causes the linting action to fail
- The action just installs the latest version; other tools like pre-commit allow for more control over updates
- Other PRs now fail the linting checks
- I don't like their style changes, Josh Horton seems to agree with me, but (my opinion) it's what one gives up using opinionated tools

Todos

Notable points that this PR has either accomplished or will accomplish.

[ ] Re-lint with Black 23

Questions

[ ] Question1

Status

[ ] Ready to go

codecov[bot] commented 1 year ago

Codecov Report

Merging #213 (58eff9e) into main (9ddddc1) will decrease coverage by 0.09%. The diff coverage is n/a.

Additional details and impacted files

jthorton commented 1 year ago

@mattwthompson thanks for doing this, I think we should be fine to merge and add pre-commit next.