search

openforcefield / openff-qcsubmit

Automated tools for submitting molecules to QCFractal
https://openff-qcsubmit.readthedocs.io/en/latest/index.html
MIT License
26 stars 4 forks source link

Set up `pre-commit`, re-run linters #218

Closed mattwthompson closed 1 year ago

codecov[bot] commented 1 year ago

Codecov Report

Merging #218 (4d64531) into main (9c9f449) will not change coverage. The diff coverage is 100.00%.

:exclamation: Current head 4d64531 differs from pull request most recent head 36d01d5. Consider uploading reports for the commit 36d01d5 to get more accurate results

Additional details and impacted files
jthorton commented 1 year ago

@mattwthompson thanks for starting this it would be great to get these fixes in! is this ready to go?

mattwthompson commented 1 year ago

Should be good, yeah - the linters appear to be passing now, even though I'm not sure CI will

mattwthompson commented 1 year ago

This, #212, and #220 are in some sort of holding pattern for getting tests passing based off of the main branch. I'm not sure the best way to proceed; this and #212 are probably standalone automation improvements that could be passed without tests passing, but I'm less than thrilled to see the tests time out or fail so often

jthorton commented 1 year ago

I think it would be great to get the automation improvements merged in then we can look into the tests so feel free to merge this and #212