openforcefield / openff-qcsubmit

Automated tools for submitting molecules to QCFractal
https://openff-qcsubmit.readthedocs.io/en/latest/index.html
MIT License
26 stars 4 forks source link

`__all__` contains wrong types #267

Closed mattwthompson closed 2 months ago

mattwthompson commented 4 months ago
In [1]: from openff.qcsubmit.results import *
---------------------------------------------------------------------------
TypeError                                 Traceback (most recent call last)
Cell In[1], line 1
----> 1 from openff.qcsubmit.results import *

File <frozen importlib._bootstrap>:1073, in _handle_fromlist(module, fromlist, import_, recursive)

File <frozen importlib._bootstrap>:1069, in _handle_fromlist(module, fromlist, import_, recursive)

TypeError: Item in openff.qcsubmit.results.__all__ must be str, not ModelMetaclass

The problem is where __all__ is defined as a list of classes instead of strings, which is required

The public names defined by a module are determined by checking the module’s namespace for a variable named all; if defined, it must be a sequence of strings which are names defined or imported by that module.

https://docs.python.org/3/reference/simple_stmts.html#import

There are a few other such instances