Re-enable codecov - Githubissues

openforcefield / openff-qcsubmit

Automated tools for submitting molecules to QCFractal

https://openff-qcsubmit.readthedocs.io/en/latest/index.html

MIT License

26 stars 4 forks source link

Re-enable codecov #291

Closed ntBre closed 1 month ago

ntBre commented 1 month ago

Based on the CI errors, I think we're just missing the token. I also changed fail_ci_if_error to true in-line with the toolkit repo.

Description

Enable codecov coverage checks in CI. There was already a step in CI.yml for this, but no token was being provided and fail_ci_if_error was false, so it was silently failing each time.

Status

[ ] Ready to go

mattwthompson commented 1 month ago

I added a token from ^1 to ^2 and re-kicked CI for fun

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.43%. Comparing base (60f4210) to head (a8ded62). Report is 22 commits behind head on main.

Additional details and impacted files

j-wags commented 1 month ago

Wow - opened and resolved in the time it took me to meet a collaborator for lunch. @mattwthompson's approval is all that's needed here. Thanks @ntBre!