openforcefield / openff-toolkit

The Open Forcefield Toolkit provides implementations of the SMIRNOFF format, parameterization engine, and other tools. Documentation available at http://open-forcefield-toolkit.readthedocs.io
http://openforcefield.org
MIT License
309 stars 90 forks source link

Support version 0.4 of SMIRNOFF vdW section #1679

Closed mattwthompson closed 1 year ago

mattwthompson commented 1 year ago

Resolves #1678

Cribbed heavily from https://github.com/openforcefield/openff-toolkit/pull/1277/files#diff-fd6b852eaa3bb076240130325c7023d4041de6b0f45bee26c509e61b8a661a23R3839-R3890

There's a dependency loop here in which Interchange needs to parse the new attributes, but can't without the changes to the toolkit - and the toolkit's tests won't pass unless Interchange is updated to handle the new attributes. This mirrors similar issues that might happen in deployment - if (say) 0.14.2 up-converts to 0.4 but for any reason a new version of Interchange isn't immediately released to support it, most of our infrastructure is broken. I'm exploring the possibility of, prior to changes in the toolkit, having Interchange automatically down-convert 0.4 to 0.3 with the intent that a subsequent release does the opposite. Currently these conversions are equivalent in information content so the conversions are not lossy. I think this can enable a smooth transition of all moving pieces, setting the stage for future changes like LJPME, and not breaking existing workflows that rely on OFFXMLs with version 0.3.

codecov[bot] commented 1 year ago

Codecov Report

Merging #1679 (f5ec529) into main (80271af) will increase coverage by 0.01%. The diff coverage is 100.00%.

Additional details and impacted files
mattwthompson commented 1 year ago

Interchange 0.3.10 up-converts 0.3 to 0.4, and also supports processing 0.4 directly. Tests here should be passing using it, and Interchange 0.3.10 should still work with versions of the toolkit that do not include this change.

mattwthompson commented 1 year ago

Thanks!

mattwthompson commented 1 year ago

I didn't investigate the docs issues, but I did start a paper trail: https://github.com/openforcefield/openff-docs/issues/21

I'm in a good mood today and investigating SetupTools changes is the sort of thing that would change that.