search

openforcefield / openff-toolkit

The Open Forcefield Toolkit provides implementations of the SMIRNOFF format, parameterization engine, and other tools. Documentation available at http://open-forcefield-toolkit.readthedocs.io
http://openforcefield.org
MIT License
309 stars 90 forks source link

Fix docs builds #1687

Closed mattwthompson closed 1 year ago

mattwthompson commented 1 year ago

Starting grasping at straws

https://pip.pypa.io/en/stable/news/#v23-2

mattwthompson commented 1 year ago

That ... worked?

mattwthompson commented 1 year ago

If I'm not missing anything, I think this is good to go.

Pinning to an old version of pip is not good, but our docs not being build is not good-er.

codecov[bot] commented 1 year ago

Codecov Report

Merging #1687 (ae2a0d5) into main (7b94401) will increase coverage by 0.21%. The diff coverage is n/a.

:exclamation: Current head ae2a0d5 differs from pull request most recent head 46ff898. Consider uploading reports for the commit 46ff898 to get more accurate results

Additional details and impacted files
j-wags commented 1 year ago

I redid the "stable" pin assignment in the 0.14.2 release around the same time as you opened this PR - I've reverted the changes to kick CI so we can tease apart whether this was the effective fix.

j-wags commented 1 year ago

Looks like the RTD build ran with no changes. Thanks for hopping on this so quickly, but I think it was doing the new release and stable-tag-setting correctly that got RTD back.