Update examples - Githubissues

openforcefield / openff-toolkit

The Open Forcefield Toolkit provides implementations of the SMIRNOFF format, parameterization engine, and other tools. Documentation available at http://open-forcefield-toolkit.readthedocs.io

http://openforcefield.org

MIT License

305 stars 90 forks source link

Update examples #1719

Closed mattwthompson closed 10 months ago

mattwthompson commented 10 months ago

[x] Resolves #1718
[x] Remove un-used examples/environment.yaml
[x] Use Sage 2.1.0
[x] Do not use Python <3.9 typing imports
[x] Use Interchange.to_openmm_simulation
[x] Re-run notebooks

review-notebook-app[bot] commented 10 months ago

Check out this pull request on

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

codecov[bot] commented 10 months ago

Codecov Report

Merging #1719 (d92528d) into main (b9bb6b2) will decrease coverage by 0.02%. The diff coverage is n/a.

:exclamation: Current head d92528d differs from pull request most recent head 32bd075. Consider uploading reports for the commit 32bd075 to get more accurate results

Additional details and impacted files

j-wags commented 10 months ago

Thanks for opening this. I'll finish this PR.