Do not allow `unique_molecules=None` when required

openforcefield / openff-toolkit

The Open Forcefield Toolkit provides implementations of the SMIRNOFF format, parameterization engine, and other tools. Documentation available at http://open-forcefield-toolkit.readthedocs.io

http://openforcefield.org

MIT License

305 stars 90 forks source link

Do not allow `unique_molecules=None` when required #1742

Open mattwthompson opened 9 months ago

mattwthompson commented 9 months ago

Closes #1485

[x] Removes MissingUniqueMoleculesError which should have always been a TypeError
- [x] Ensured this case is not handled in MissingUniqueMoleculesError (not that it could be)
[x] Tag issue being addressed
[x] Add tests
[x] Update docstrings/documentation, if applicable
[x] Lint codebase
[x] Update changelog

codecov[bot] commented 5 months ago

Codecov Report

Merging #1742 (b2131cb) into main (118918c) will decrease coverage by 0.01%. The diff coverage is n/a.

Additional details and impacted files