Improve `Topology` compatibility with `_SimpleMolecule`

openforcefield / openff-toolkit

The Open Forcefield Toolkit provides implementations of the SMIRNOFF format, parameterization engine, and other tools. Documentation available at http://open-forcefield-toolkit.readthedocs.io

http://openforcefield.org

MIT License

302 stars 88 forks source link

Improve `Topology` compatibility with `_SimpleMolecule` #1784

Closed mattwthompson closed 5 months ago

mattwthompson commented 7 months ago

[ ] Tag issue being addressed
[ ] Add tests
[ ] Update docstrings/documentation, if applicable
[ ] Lint codebase
[ ] Update changelog

codecov[bot] commented 7 months ago

Codecov Report

Merging #1784 (0c9af64) into main (9b23790) will decrease coverage by 0.11%. The diff coverage is 94.54%.

:exclamation: Current head 0c9af64 differs from pull request most recent head fd095d4. Consider uploading reports for the commit fd095d4 to get more accurate results

Additional details and impacted files

j-wags commented 7 months ago

Unless it's really important to getting things working, I'd prefer for this PR to not be the place where we introduce a hard dep on pydantic.