Annotate most everything

openforcefield / openff-toolkit

The Open Forcefield Toolkit provides implementations of the SMIRNOFF format, parameterization engine, and other tools. Documentation available at http://open-forcefield-toolkit.readthedocs.io

http://openforcefield.org

MIT License

302 stars 88 forks source link

Annotate most everything #1798

Closed mattwthompson closed 3 months ago

mattwthompson commented 6 months ago

Happy holidays @Yoshanuikabundi - I think I'll break this up into a few smaller changes but this is the gist of what is encompassed

[x] Move annotations from docstrings to function signatures
[x] Use check_untyped_defs = True
[x] Tag issue being addressed #1791
[ ] Add tests
[x] Update docstrings/documentation, if applicable
[x] Lint codebase
[ ] Update changelog

codecov[bot] commented 6 months ago

Codecov Report

Merging #1798 (45c7876) into main (b739698) will decrease coverage by 0.02%. The diff coverage is 95.92%.

Additional details and impacted files

mattwthompson commented 3 months ago

Thanks for the review @Yoshanuikabundi - there are three loose ends I'm leaving unresolved, but I think everything else here is working!