search

openforcefield / openff-toolkit

The Open Forcefield Toolkit provides implementations of the SMIRNOFF format, parameterization engine, and other tools. Documentation available at http://open-forcefield-toolkit.readthedocs.io
http://openforcefield.org
MIT License
311 stars 90 forks source link

Ensure v1 `ValidationError` is checked in test #1814

Closed mattwthompson closed 8 months ago

mattwthompson commented 8 months ago

The current code blindly does from Pydantic import ValidationError, which later causes problems when attempting to later catch the error which is always from v1.

This works locally with each of v1 and v2 installed

codecov[bot] commented 8 months ago

Codecov Report

Merging #1814 (21ef341) into main (cd88bce) will decrease coverage by 0.02%. Report is 2 commits behind head on main. The diff coverage is n/a.

Additional details and impacted files