search

openforcefield / openff-toolkit

The Open Forcefield Toolkit provides implementations of the SMIRNOFF format, parameterization engine, and other tools. Documentation available at http://open-forcefield-toolkit.readthedocs.io
http://openforcefield.org
MIT License
301 stars 88 forks source link

Unused, undocumented argument `assume_missing_is_default` in `check_handler_compatibility` #1843

Open mattwthompson opened 3 months ago

mattwthompson commented 3 months ago

Is your feature request related to a problem? Please describe.

https://github.com/openforcefield/openff-toolkit/blob/b739698d4187943ac8e31c59a0866b60247c6ed5/openff/toolkit/typing/engines/smirnoff/parameters.py#L3201

https://github.com/openforcefield/openff-toolkit/blob/b739698d4187943ac8e31c59a0866b60247c6ed5/openff/toolkit/typing/engines/smirnoff/parameters.py#L3268

Describe the solution you'd like

Remove these since they do nothing but confuse me and any user who tries to understand what they do

Describe alternatives you've considered

Additional context

In this PR, this argument was removed from several other methods of the same name, but not these two: https://github.com/openforcefield/openff-toolkit/commit/ea4231f661dd155058d7e7480ffefa1f7f1c7681

This is an "API break" except it currently does nothing and should not exist