search

openforcefield / smarty

Chemical perception tree automated exploration tool.
http://openforcefield.org
MIT License
19 stars 8 forks source link

[WIP] Add coverage to travis tests #265

Open bannanc opened 6 years ago

bannanc commented 6 years ago

I think this is all we have to do to generate coverage reports for tests, if it works here I can do it on openforcefield also.

davidlmobley commented 6 years ago

The README.md shows the code coverage badge, but the status is unknown. Is there a way to tell whether it's working before merging?

(Often I've seen code coverage tests/reports as part of a PR, but turning that on -- likely a toggle on GitHub's settings -- perhaps is a separate test. And maybe the badge only reports on coverage of master?)

Your branch is also out-of-date.

bannanc commented 6 years ago

Yes, I meant to put a [WIP] on this when I realized there was something up with the tests. The only coverage I've done was with pytest and directly to a master branch so I'm not sure if the report will show up before this is merged into the master.

bannanc commented 6 years ago

For the record this is trying to address #262 and #264

bannanc commented 5 years ago

I've been revisiting my github PRs and Issues and found this. I think it would be good for our (mine and @camizanette 's) portfolios for this to not be failing. I think the current issues here relate to the openeye license being expired and maybe a version problem with networkx. I'm going to try to get things passing and then maybe pin versions so we know it is reproducible within the environment it was developed in.

bannanc commented 5 years ago

Note on that, going to doesn't mean immediately, just means at some point.

davidlmobley commented 5 years ago

All for pinning versions; having the tests frequently start failing because of a change in somethign we don't control is frustrating.