openforcefield / smirnoff99Frosst

A general small molecule force field descended from AMBER99 and parm@Frosst, available in the SMIRNOFF format
Creative Commons Attribution 4.0 International
28 stars 9 forks source link

Conda installing on different channels #50

Closed bannanc closed 4 years ago

bannanc commented 7 years ago

We have the force field on the mobleylab conda channel and most other things in the omnia channel. I think it would be better for everything for open-forcefield-group to be in the same channel, at least in the long run. Should we make an OFF channel? Or move everything into Omnia?

jchodera commented 7 years ago

Omnia for now. Later migrate to conda-forge following the omnia roadmap. Otherwise it will unnecessarily increase our maintenance burden, and my group does not have the capacity to handle that, so it would be all on the Mobley lab to support if we go any other way.

davidlmobley commented 7 years ago

We had to temporarily put this into the Mobleylab channel because of the lag in getting things into Omnia (Nathan needed something conda-installable for Orion in the crunch around CUP that worked immediately so we couldn't wait overnight). I'm fine with moving it into Omnia.

@jchodera - you refer to the omnia roadmap; where is this? And when is the migration to conda-forge happening? Somewhat relatedly, @nividic has been trying to get LOMAP working with Python 3 on Omnia but because of the huge number of out-of-date packages in the channel (I believe he mentioned RDKit among others) he's worrying he is going to have to put it in a different channel instead or make himself responsible for updating a wide variety of packages in Omnia, which he doesn't have time to do. What's the plan for dealing with maintenance of non-Omnia packages in the Omnia channel? I totally understand your group not wanting to take on unnecessary maintenance burden, but it's also (in cases like LOMAP) not clear how my group can avoid taking on unnecessary maintenance burden to get things INTO Omnia.

jchodera commented 7 years ago

@jchodera - you refer to the omnia roadmap; where is this?

Right now, it's just summarized in issues.

And when is the migration to conda-forge happening?

As soon as we have time to switch from putting out fires to updating the build system, we are finishing https://github.com/omnia-md/conda-recipes/pull/667 to switching to a CentOS 6 based build system and add the conda-forge channel as a prerequisite. At that point, package maintainers can start to migrate packages that don't depend on OpenMM over to conda-forge or use conda-forge packages as a dependency without it breaking everything.

We'll also work to migrate openmm to conda-forge once that happens, which will take a bit more work because of the more complex build environment.

Somewhat relatedly, @nividic has been trying to get LOMAP working with Python 3 on Omnia but because of the huge number of out-of-date packages in the channel (I believe he mentioned RDKit among others) he's worrying he is going to have to put it in a different channel instead or make himself responsible for updating a wide variety of packages in Omnia, which he doesn't have time to do. What's the plan for dealing with maintenance of non-Omnia packages in the Omnia channel? I totally understand your group not wanting to take on unnecessary maintenance burden, but it's also (in cases like LOMAP) not clear how my group can avoid taking on unnecessary maintenance burden to get things INTO Omnia.

Which packages specifically do you need updated (besides rdkit)?

If you can go straight into conda-forge, that might be a better option if you don't need any omnia dependencies. But you'll have to dive in on your own.

nividic commented 7 years ago

Hi there, let me finish to updating Lomap to py3 and I'll let you asap with packages need to be updated. I'm still testing. I should finish during this weekend

bannanc commented 7 years ago

Ok, thanks!

So long story short we should migrate smirnoff99Frosst to the omnia channel for now.

nividic commented 7 years ago

I checked the anaconda omnia repository and I think the only missing package should be pygraphviz version 1.4rc1 for python 3.4 linux and OS X

davidlmobley commented 7 years ago

@nividic - so you're saying pygraphviz needs an update from 1.3 to 1.4rc1? Can you just do a PR to update the conda recipe?

jchodera commented 7 years ago

I checked the anaconda omnia repository and I think the only missing package should be pygraphviz version 1.4rc1 for python 3.4 linux and OS X

@Lnaden is about to merge https://github.com/omnia-md/conda-recipes/pull/761 which will allow you to use conda-forge dependencies, so if you can find what you need there, you'll be able to use it without having to make any additional recipes for dependencies.

nividic commented 7 years ago

I cannot find the package on conda-forge. I'll try to build it in omnia

jchodera commented 7 years ago

I think you just have to update this part of the omnia recipe to the latest pip version.

davidlmobley commented 7 years ago

Yes, @nividic - you should be able to just update the recipe.

nividic commented 7 years ago

I updated the recipe and I pulled a request on omnia yesterday night. I used I recipe that I download from anaconda. On my linux box I was able to build the latest version of pygraphviz by using it. I also uploaded it in my anaconda repository: https://anaconda.org/nividic

davidlmobley commented 7 years ago

Ah, this is the relevant PR: https://github.com/omnia-md/conda-recipes/pull/765

bannanc commented 4 years ago

I was checking another old issue when I saw this one, I think it can be closed right?

j-wags commented 4 years ago

Yes, thanks for the reminder. I think this can be closed, along with a few others.