Closed mattwthompson closed 9 months ago
Jotting down some notes:
After reading the docs and trying to grok the implementation in some OpenMM source code, I'm moving to just use "Ewald3D"
. I'm not confident that a conducting boundary is not used, but as I understand it there is no concept of a dielectric medium for the vdW term, so I lean towards not including it.
At least in OpenMM world, the incompatibility with Lorentz-Berthelot mixing rules seems to only be in reciprocal space. The docs imply to me that geometric mixing rules are used in reciprocal space no matter what, and that's just an acceptable approximation. From this I'm inclined to treat it as an implementation detail instead of specifying that LJPME cannot ever be used with Lorentz-Berthelot. In fact, GROMACS seems to have no problem doing that.
Thanks all for the reviews - I think I've covered everything brought up, but I'll leave this open for a short period of time in case I've introduced new typos or missed an important detail from our discussion in the meeting
https://github.com/openforcefield/standards/pull/44#discussion_r1221736601valid but not directly relevanthttps://github.com/openforcefield/standards/pull/44#discussion_r1221739961not in scope here