openforge / capacitor-game-connect

A capacitor plugin to connect to both Apple Game Center and Google Play Game Services libraries.

22 stars 10 forks source link

fix(definitions): add player_name and player_id to signIn #10

Closed PaulPaulDevelops closed 1 year ago

PaulPaulDevelops commented 1 year ago

Pull request type

[X] Bugfix
[ ] Feature
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] Documentation content changes
[ ] E2E Test(s)
[ ] Other (please describe):

What is the current behavior?

When using the sign-in function, it has Promise as if it returns nothing - but in actuality it does return data.

What is the new behavior?

Add in the information in the definition about what is being returned.

Does this introduce a breaking change?

[ ] Yes
[X] No

Other information