search

openforis / fra-platform

7 stars 6 forks source link

Forest area as proportion of total land area SDG - should be estimated bases on the latest available NDP after 2020 #3203

Closed pengchenglai closed 6 months ago

pengchenglai commented 11 months ago

@minotogna

Describe the bug Forest area as proportion of total land area SDG indicator uses the linear trend even though there is a new NDP after 2020.

To Reproduce See Australia(screenshots below)

Expected behavior If the latest data of NDP after 2020 is available, the Forest area as proportion of total land area should be estimated based on the latest data of NDP not the 2020 data

Screenshots image image

sorja commented 8 months ago

@pengchenglai After working with this I think we must take into account several cases Reference PR: https://github.com/openforis/fra-platform/pull/3427 Could you be so kind to verify I did not miss any?

Let me know if you can think of any other cases and if any of the above logic should be changed.

In short:

Questions:

Thanks

pengchenglai commented 8 months ago

@sorja

Thank you. In reality, this scenario usually does not occur because the data for 2025 would be repeated from the data for 2020 or any existing data reported in previous reports if NC does not have it for 2025. : If single value exists exists, is it preferred to use 2020 or 2025 to interpolate / extrapolate?

pengchenglai commented 8 months ago

@sorja

We could have a quick talk later today or tomorrow to resolve this issue which might make it easy to clarify the cases if possible

minotogna commented 7 months ago

@pengchenglai this issue is not 100% clear: here is an example of the formula for year 2021.

extentOfForest.forestArea['2021'] ? 
                extentOfForest.forestArea['2021'] / extentOfForest.totalLandArea['2021'] * 100 : 
                (
                  (extentOfForest.forestArea['2020'] / extentOfForest.totalLandArea['2020'] * 100 > 0 && extentOfForest.forestArea['2025'] / extentOfForest.totalLandArea['2025'] * 100) > 0 ? 
                    (extentOfForest.forestArea['2020'] / extentOfForest.totalLandArea['2020'] * 100 + ((extentOfForest.forestArea['2025'] / extentOfForest.totalLandArea['2025'] * 100 - extentOfForest.forestArea['2020'] / extentOfForest.totalLandArea['2020'] * 100) / 5 * 1)) 
                    : null
                )

how should we modify this ? thank you

pengchenglai commented 7 months ago

@minotogna

True, the code works for 2021. However, if the data is for 2023, then we need to add one more step to check if there are any NDPs available between 2020 and 2025.

In the case of Australia, there is no NDP for 2023, but there are NDPs for 2021 and 2022. Therefore, data from 2022 and 2025 should be used for linear estimation for the Forest area as proportion of total land area.

minotogna commented 7 months ago

@minotogna

True, the code works for 2021. However, if the data is for 2023, then we need to add one more step to check if there are any NDPs available between 2020 and 2025.

In the case of Australia, there is no NDP for 2023, but there are NDPs for 2021 and 2022. Therefore, data from 2022 and 2025 should be used for linear estimation for the Forest area as proportion of total land area.

@pengchenglai @sorja can we have a chat tomorrow morning 10am Rome time ?

pengchenglai commented 7 months ago

If we now use the data from 2020 and 2025 to estimate the data for 2023, the value will be lower than that of 2022. However, we know it should be the same as the value for 2022, which is 17.36.

image

pengchenglai commented 7 months ago

@minotogna

For me it is fine