search

openforis / fra-platform

7 stars 6 forks source link

ODP: Can't re-enable disabled ODPs #3365

Closed sorja closed 9 months ago

sorja commented 10 months ago

Describe the bug Bug: https://github.com/openforis/fra-platform/blob/9a7a83ab8540fa450be9b46ec6f59316a1b572d0/src/client/pages/Section/SectionHeader/ForestCharacteristics/ForestCharacteristics.tsx#L23-L26

hasOriginalDataPointData is always false if ODPs disabled: ODPs are not fetched Check if this is correct

So we currently return 'null' and not the button if the ODP has no data (...=doesn't have the data that is never fetched in the first place!)

To Reproduce Steps to reproduce the behavior:

  1. Go to any country with odps, section 1b
  2. Click on 'Don't use ODPs'
  3. Refresh
  4. See error (button is not there)

Expected behavior Button is there

minotogna commented 9 months ago

@sorja unable to reproduce. can u provide a video with use case ?

sorja commented 9 months ago

@sorja unable to reproduce. can u provide a video with use case ?

Unable to replicate, maybe it was solved