search

openfpga-cores-inventory / analogue-pocket

https://openfpga-cores-inventory.github.io/analogue-pocket/
MIT License
61 stars 12 forks source link

fix: specify assets for Spiritualized.SuperGB core #647

Closed omjadas closed 2 months ago

omjadas commented 2 months ago

sgb_boot.bin and sgb_snes.smc are needed for the core to be used

joshcampbell191 commented 2 months ago

Thank you for the contribution.

Although these files are required to run the core, they haven't been marked as such required in data.json provided by the core. This would explain why they aren't exposed in the API. 

      {
        "name": "SGB BIOS SNES",
        "id": "0x103",
        "required": false,
        "filename": "sgb_snes.smc",
        "parameters": "0x2",
        "extensions": [
          "smc"
        ],
        "size_exact": null,
        "size_maximum": 522488,
        "address": "0x00000000"
      },
      {
        "name": "SGB BIOS GB",
        "id": "0x104",
        "required": false,
        "filename": "sgb_boot.bin",
        "parameters": "0x2",
        "extensions": [
          "bin"
        ],
        "size_exact": 256,
        "address": "0x60000f00"
      }

A PR would have to be made against the core https://github.com/spiritualized1997/openFPGA-Super-GB repository to correct this issue.