openframeworks / apothecary

This is the OpenFrameworks library apothecary. It mixes formulas and potions to build and update the C/C++ lib dependencies.
Other
56 stars 51 forks source link

glm regression - re generating bleeding libs will *probably* fix #346

Closed dimitre closed 6 months ago

dimitre commented 6 months ago

Hey @danoli3 I think it worth to manually trigger bleeding releases again glm 0.9.9.9 had some strange issues, now it seems to be fixed in 1.0.0 as the formula is pointing to master it is only a matter of re-generating ( I think ) Thanks

danoli3 commented 6 months ago

Roger firing on upstream

danoli3 commented 6 months ago

Oh its actually already targeting master so its should be fine and already at 1.0.0.

# tools for git use
GIT_URL=https://github.com/g-truc/glm
GIT_TAG=master
danoli3 commented 6 months ago

Building now should be live within the hour across all platforms @dimitre

dimitre commented 6 months ago

Thanks @danoli3 it is unfortunate a regression still present in 1.0.0 I had to revert back to 0.9.9.8 to make things work here.

ofTheo commented 6 months ago

@dimitre I’m curious what the 0.9.9 and 1.0.0 issues are?

dimitre commented 6 months ago

1.0.0

In file included from /Volumes/tool/ofw/apps/werkApps/ScenesPBR2/src/ofApp.cpp:1:
In file included from src/ofApp.h:6:
In file included from /Volumes/tool/ofw/addons/ofxMicroUI/src/ofxMicroUI.h:20:
In file included from ../../../libs/openFrameworks/graphics/ofImage.h:3:
In file included from ../../../libs/openFrameworks/gl/ofTexture.h:3:
In file included from ../../../libs/openFrameworks/graphics/ofGraphicsBaseTypes.h:3:
In file included from ../../../libs/openFrameworks/types/ofColor.h:5:
In file included from ../../../libs/glm/include/glm/gtx/wrap.hpp:16:
In file included from ../../../libs/glm/include/glm/gtx/../glm.hpp:118:
In file included from ../../../libs/glm/include/glm/gtx/../vec3.hpp:5:
In file included from ../../../libs/glm/include/glm/gtx/.././ext/vector_bool3.hpp:5:
In file included from ../../../libs/glm/include/glm/gtx/.././ext/../detail/type_vec3.hpp:446:
In file included from ../../../libs/glm/include/glm/gtx/../detail/type_vec3.inl:834:
../../../libs/glm/include/glm/gtx/../detail/type_vec_simd.inl:924:30: error: template argument for non-type template parameter must be an expression
                        return !compute_vec_equal<float, Q, false, 32, true>::call(v1, v2);
dimitre commented 6 months ago

nevermind @ofTheo @danoli3 I was using an unpopular define in this particular project

define GLM_FORCE_NEON

it works well with 1.0.0

ofTheo commented 6 months ago

ahh okay - awesome! 👍

danoli3 commented 6 months ago

Looking at the repo more, surely we should just compile this here