Closed alexhojinpark closed 7 months ago
I think this PR has a merge conflict @alexhojinpark
But if this doesn't work we might need to use absolute urls like:
![install dialog for the command line tools](https://openframeworks.cc/setup/xcode/xcode_setup_assets/install-dialog.webp)
@alexhojinpark it's not shown on offline preview in repo because markdown files will be generate to static html file so leave image url as original will be better I guess. hope this helps.
@ofTheo @icq4ever Thank you for the help. I've added absolute URLs. Should I create a new pull request for these changes? I'm not very familiar with the pull request process.
as I know as you update and pushed to your cloned repo(I mean github), previous PR update automatically as well.
On Wed, Dec 13, 2023 at 11:02 alexhojinpark @.***> wrote:
@ofTheo https://github.com/ofTheo @icq4ever https://github.com/icq4ever Thank you for the help. I've added absolute URLs. Should I create a new pull request for these changes? I'm not very familiar with the pull request process.
— Reply to this email directly, view it on GitHub https://github.com/openframeworks/ofSite/pull/816#issuecomment-1853150369, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAEBS3AAI7WJ2P2RFRCXYGDYJEEE5AVCNFSM6AAAAABAR7F7TCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNJTGE2TAMZWHE . You are receiving this because you were mentioned.Message ID: @.***>
Thank you :)
@alexhojinpark still there are conflicts.
@icq4ever I'm assuming I have no permission to write or resolve conflicts, or I've done something wrong in Git commands while merging. I did a 'git pull' from master, switched to my branch, added, committed, and pushed to master.
Not sure what the issue was, but I fixed it! thanks @alexhojinpark
@ofTheo @icq4ever Thank you so much for the help :) have a great day!
Reference: #815
I attempted to locate a path for images from ko/setup/xcode/xcode_setup_assets/install-dialog.webp, but couldn't find a solution(Image does not show up on my preview). I tested with VS Code default preview, and it seems adding ./ might work.
So, changing this:
![install dialog for the command line tools](xcode_setup_assets/install-dialog.webp)
to:
![install dialog for the command line tools](./xcode_setup_assets/install-dialog.webp)
Hope it works, Thank you.