search

openframeworks / openFrameworks

openFrameworks is a community-developed cross platform toolkit for creative coding in C++.
http://openframeworks.cc
Other
9.97k stars 2.55k forks source link

ofMesh::sphere is not a closed mesh #2740

Open julapy opened 10 years ago

julapy commented 10 years ago

noticed the other day that the ofMesh::sphere is not being created as a closed mesh, which i think it should be. the first and last row of vertices are being duplicated, when i think they should be the same and joined.

all the 3d software that ive used create a sphere primitive as a closed mesh and i think this is the standard.

i can make this change but just wanted to throw it out there first in case someone has a strong opinion against this.

tgfrerer commented 10 years ago

My hunch would be that this has something to do with the normals.

When you use flat shading drawing the normals, does the mesh look the same as it is now compared to an alternative 'closed' version? If so, the closed version would be nicer, I'd agree.

typed on toucg

On 20 Dec 2013, at 23:56, lukasz karluk notifications@github.com wrote:

noticed the other day that the ofMesh::sphere is not being created as a closed mesh, which i think it should be. the first and last row of vertices are being duplicated, when i think they should be the same and joined.

all the 3d software that ive used create a sphere primitive as a closed mesh and i think this is the standard.

i can make this change but just wanted to throw it out there first in case someone has a strong opinion against this.

— Reply to this email directly or view it on GitHub.