Merge ofxCv into openFrameworks

[kylemcdonald]

I propose to add it as another addon, and deprecate ofxOpenCv until finally dropping it with 1.0.

If there is support for this approach I can send a PR. The biggest issue is that there are a lot of examples, which would really inflate the addons examples folder.

I've also been planning for some time to merge ofxFaceTracker into ofxCv, but having ofxFaceTracker in the core would be harder because it has a non-commercial use license -- and we'd be back in an fmod situation.

[arturoc]

+1 i guess we can have an examples/cv folder with all the examples related to computer vision, cv is one of the strengths of OF so i guess it makes sense to have a specific folder for examples. in terms of size i don't think it should be that much

[arturoc]

only thing is the way you use namespaces which is particular to ofxCv and not used anywhere else in OF

[kylemcdonald]

what if we changed the namespace from ofxCv to of::cv?

then when you say using namespace of; you can say either cv::dilate(Mat) (coming from the cv namespace) or cv::dilate(ofImage) (coming from the of::cv namespace).

i would compare this to the way that ofFile extends fstream. you can use all the advanced functionality of fstream if you want, but if you see something that's in the OF documentation then you know it should be 'easy'.

[ofZach]

Personally, I think there such a wealth of example code based around ofxOpenCv that deprecating it / removing it will be pretty painful -- An alternative approach would be to not deprecate ofxOpenCv but find a way to wrap it so it sits w/ ofxCv, as a means of bringing ofxCv into the core and making some sort of layer that can allow older code to compile. We've discussed this earlier, I think the main issue is some sort of concept of ROI.

(at any rate, am very supportive of ofxCv in the core. Just worried about removing things from core / core addons)

[kylemcdonald]

i've thought about this a bit zach, and i'm not sure it makes any sense to try and bridge ofxCv and ofxOpenCv. it's totally cool if ofxOpenCv is just left alone, it will just be a little confusing to new users.

curious what other examples are out there, maybe it's the examples that need to be implemented in ofxCv instead?

[ofZach]

I'm thinking specifically of things like -

https://github.com/joshuajnoble/Programming-Interactivity-Code

(and other major sets of learning examples code like Jeff Crouses, etc ) that might be hurt if ofxOpenCv is removed from the core. There's about 5000+ hits on github for including ofxOpenCv, and it's pretty major projects and things people have made.

I think a compatibility layer makes sense to help for transitioning but let's at least figure out how to elevate ofxCv to core addon.

[ofTheo]

yeah I think it is important to review both ofxOpenCV and ofxCv and see what changes ( if any ) either need going forward. I personally still use ofxOpenCv for my projects - so I need to spend some time with the ofxCv addon to get more familiar with it.

Either way if we bring in the ofxCv addon I wouldn't see ofxOpenCV going away for a long time.

However ofxOpenCv is legacy at the moment ( with OpenCV moving to a more C++ approach ) - so it seems like a good time to review.