search

openframeworks / openFrameworks

openFrameworks is a community-developed cross platform toolkit for creative coding in C++.
http://openframeworks.cc
Other
9.94k stars 2.55k forks source link

nightly release now doesn't include example files for Visual Studio #7856

Closed ofTheo closed 9 months ago

ofTheo commented 9 months ago

Just tested a nightly and while there are VS Code project files there are no Visual Studio files ( for the examples )

ofTheo commented 9 months ago

Okay from testing locally this seems to be due to adding the vscode template to the generate all examples.

running: apps/projectGenerator/commandLine/bin/projectGenerator_debug --recursive -pvs -tvscode

doesn't work

running: apps/projectGenerator/commandLine/bin/projectGenerator_debug --recursive -pvs,vscode

does work

I think this is due to: https://github.com/openframeworks/projectGenerator/commit/9a138d45d000d36f953730949c35c334ca97f84b

Going to switch the nightly builds to use the comma separated approach and fix the PG separately.

dimitre commented 9 months ago

I've noticed the same for XCode projects, osx is packaging with only vscode. I was wondering about create_package.sh

        #add vscode to all platforms apart from ios/tvos/android
        if [ "$pkg_platform" == "android" ] || [ "$pkg_platform" == "ios" ]; then
            pg_template=" "
        else
            pg_template="-tvscode"
        fi
ofTheo commented 9 months ago

yeah just realized Xcode too as well! going to switch it to use the non template approach in create_package and then fix it properly in PG

ofTheo commented 9 months ago

okay this is fixed now and current nightly should be good - phew!