openframeworks / openFrameworks

openFrameworks is a community-developed cross platform toolkit for creative coding in C++.
http://openframeworks.cc
Other
9.98k stars 2.55k forks source link

MAX_BUFFER_SIZE of UdpSocket in ofxOsc on Windows Env #8106

Closed 2bbb closed 2 months ago

2bbb commented 2 months ago

on Windows, win32/UdpSocket.cpp

https://github.com/openframeworks/openFrameworks/blob/78a6a538615e53b32285bd989430a94ac817f927/addons/ofxOsc/libs/oscpack/src/ip/win32/UdpSocket.cpp#L450-L452

on posix,

https://github.com/openframeworks/openFrameworks/blob/78a6a538615e53b32285bd989430a94ac817f927/addons/ofxOsc/libs/oscpack/src/ip/posix/UdpSocket.cpp#L463-L469

is this an intentional limitation on size on Windows?

2bbb commented 2 months ago

I refered source code of original oscpack, and I find posix UdpSocket was modified. https://github.com/RossBencina/oscpack/blob/3e7e3a102e316d75fe176885a6dd08f216f2eac0/ip/posix/UdpSocket.cpp#L443-L445

so, I think It seems a mistake win32 UdpSocket hasn't been modified. I will make PR.

dimitre commented 2 months ago

Great. it seems oscpack is stale, not receiving new PRs. this other fork has interesting changes https://github.com/tai-studio/oscpack

danoli3 commented 2 months ago

Just check if max size can be returned for windows. Looks like need to fix for sure!

On Tue, 3 Sep 2024 at 9:36 AM, 2bit @.***> wrote:

on Windows, win32/UdpSocket.cpp

https://github.com/openframeworks/openFrameworks/blob/78a6a538615e53b32285bd989430a94ac817f927/addons/ofxOsc/libs/oscpack/src/ip/win32/UdpSocket.cpp#L450-L452

on posix,

https://github.com/openframeworks/openFrameworks/blob/78a6a538615e53b32285bd989430a94ac817f927/addons/ofxOsc/libs/oscpack/src/ip/posix/UdpSocket.cpp#L463-L469

is this an intentional limitation on size on Windows?

— Reply to this email directly, view it on GitHub https://github.com/openframeworks/openFrameworks/issues/8106, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAGK2HDWWFEHFKFMW2E2SYDZUVRIJAVCNFSM6AAAAABNRQL77GVHI2DSMVQWIX3LMV43ASLTON2WKOZSGUYDEMJUGE3TGNA . You are receiving this because you are subscribed to this thread.Message ID: @.***>