search

openframeworks / openFrameworks

openFrameworks is a community-developed cross platform toolkit for creative coding in C++.
http://openframeworks.cc
Other
9.97k stars 2.55k forks source link

osx nightly signing errors for various libs #8135

Closed chilina closed 1 month ago

chilina commented 1 month ago

A recent nightly build for osx (of_v20240923_osx_release) seems to have some signing errors for various libs:

/Users/chilina/of_v20240923_osx_release/libs/pixman/lib/macos/pixman.xcframework:1:1 The signature of “pixman.xcframework” cannot be verified. /Users/chilina/of_v20240923_osx_release/libs/rtAudio/lib/macos/rtAudio.xcframework:1:1 The signature of “rtAudio.xcframework” cannot be verified.

This was noted in #8126 but its a separate issue from that one. Theo could fix it with:

codesign --remove-signature libs/*/lib/macos/*.xcframework
codesign --remove-signature addons/*/libs/*/lib/macos/*.xcframework

forum thread: https://forum.openframeworks.cc/t/macos-15-probably-you-downloaded-the-wrong-package/43919

ofTheo commented 1 month ago

In a pinch we could add:

codesign --remove-signature libs/*/lib/macos/*.xcframework
codesign --remove-signature addons/*/libs/*/lib/macos/*.xcframework

To the nightly packing script - at least that way we don't need to change anything in apothecary which is much harder to wrangle.

ofTheo commented 1 month ago

Closed by: https://github.com/openframeworks/apothecary/commit/57213f40c4e8c0a12fcf4d5ee10333fa78014e0b

But there are still some issues with the nightly builds. Addon examples are referring to libs being in osx but apothecary is packaging them in macos will open another issue for that.

roymacdonald commented 1 month ago

But there are still some issues with the nightly builds. Addon examples are referring to libs being in osx but apothecary is packaging them in macos will open another issue for that.

Hi @ofTheo, I have this issue solved in my PG updates PR. It works well for me on macos. Maybe you should use it for the nightly builds?

ofTheo commented 1 month ago

@roymacdonald - thank you!!! If that PR is not quite ready to be merged are the changes that make osx/macos work equally fairly easy to pull out into another PR?

roymacdonald commented 1 month ago

@ofTheo The changes I have done mostly, if not all, address macos. But I did some drastic changes to the ofAddon class which I have not tested on other platforms (which is mostly about encapsulating its behaviour). So, I am quite positive that it will work accross all platforms without problems or even solving some, but just isolating the macos part seems hard as a lot of it has to do with what happens in the ofAddon class. But I will try setup my windows/linux machine to do these tests during the weekend.