search

openframeworks / openFrameworks

openFrameworks is a community-developed cross platform toolkit for creative coding in C++.
http://openframeworks.cc
Other
9.98k stars 2.55k forks source link

Removal of FMOD linking and dylib copying on osx, since it is not being used #8152

Closed roymacdonald closed 4 weeks ago

roymacdonald commented 1 month ago

FMOD is NOT being used on osx and still the dylib is being linked and copied into the app's bundle. this PR removes such.

It is not only disabled by default, it is not possible to enable simply by modifiing the Project.xconfig file as OF_NO_FMOD is being defined in ofConstants.h . Even if I wanted to use FMOD, it will not be that straight forwards.

OF_NO_FMOD defined in ofConstants.h is not the same as the one that is read by xcode_project.sh. The one that the latter reads is the one defined in Project.xcconfig, that is why it needs to be set in it.

This will not break anything as not using FMOD is the default behaviour and not really possible to change by just passing a flag.

Although, I think it is still reasonable to keep the dylib in the core for legacy purposes. (Eventually we should move it into an addon with all fmod related classes)

I guess that it was supposed to be the same variable but it is not.

NickHardeman commented 1 month ago

+1 For moving FMOD out of the core either to an add on or removing it all together.

ofTheo commented 4 weeks ago

Let's do it! Hallelujah!!! There has got to be an issue we can close with this.

Oh yes - and it's an oldey in the 3 digits!! #167

ofTheo commented 4 weeks ago

only took 14 years ;-)

danoli3 commented 4 weeks ago

Oh wow! Yay!

On Thu, 24 Oct 2024 at 3:10 am, Theodore Watson @.***> wrote:

only took 14 years ;-)

— Reply to this email directly, view it on GitHub https://github.com/openframeworks/openFrameworks/pull/8152#issuecomment-2432747930, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAGK2HEVWT2FLIC5CZDMXETZ47C6DAVCNFSM6AAAAABQG7PRW2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMZSG42DOOJTGA . You are receiving this because you are subscribed to this thread.Message ID: @.***>