search

openframeworks / projectGenerator

repo for centralizing work on a tool to generate OF projects
84 stars 74 forks source link

Javascript Error with the Project Generator #218

Closed ofTheo closed 4 years ago

ofTheo commented 5 years ago

see: https://github.com/openframeworks/openFrameworks/issues/6382

Note: I don't see this issue with the nightly on macOS.

This issue might be related with:

205

206

207

ofTheo commented 5 years ago

ping @hiroMTB

If there is an easy fix to fix the error without losing the new IDE selection support would be great to do a PR so we can do a release.

Thanks!

rossanag commented 5 years ago

I have to say after download the projectGenerator project from github and installed it, the message disappeared, however I am not able to pick a platform, by default XCode is set and I can't change it. Plus, I am using Ubuntu 19.04. Thanks!

hiroMTB commented 5 years ago

Hello, thanks for testing my update. As @bakercp mentioned in https://github.com/openframeworks/openFrameworks/issues/6382, npm install or npm update should solve this issue. (Or maybe we need to update /frontend/npm-shrinkwrap.json)

This is because of new npm nodule named 'n-readline'. I used this to read template.config files at here .

Right now I compiled frontend on macOS and Window 10 and I dont see any warning popup. The platform dropdown UI works ok too. Last time I tested on Ubuntu 16.04 but I can not test right now.

Could you please run npm update and if it works we can add this line in build script.

hiroMTB commented 5 years ago

To be short,

hiroMTB commented 5 years ago

I sent PR above. I think Solution A is better. This way we can make PG frontend identical. Solution B tries to use latest npm package, so each app will be different depends on the timing of generation.

arturoc commented 5 years ago

Thanks @hiroMTB, @rossanag can you check that your error is also gone after this change? should be in tomorrows nightly build

hiroMTB commented 5 years ago

Thanks for merge, I can check tmrw's nightly but only for osx and win.

rossanag commented 5 years ago

Sorry for the late response, the error message is gone, the only issue I have now is that the MAC platform is set by default and I can choose another one. I tryed solution A. The only way to get it working is using command line

projectGenerator -o"/path/toOF" -a"ofxGui ofxCv ofxNI2" -t"vscode" /home/rossig/openFrameworks/apps/myApps/NI2

hiroMTB commented 5 years ago

@rossanag Thank you for checking. It seems latest nightly is not ready yet, I will send you ping again.

Edit: Please check "advanced options" checkbox. Then you can select and deselect platforms.

About the default platform issue, I will take a look.

hiroMTB commented 5 years ago

@arturoc Nightly is still old, does it fail? Where can we check build log?

arturoc commented 5 years ago

hey, yeah the problem is nightlies need a commit to the main repo, otherwise the server considers there's no change and it doesn't trigger the nightly. Yesterday there was a change but now the main repo is broken cause of the new glm version. Once those are fixed the nightlies will get built properly

hiroMTB commented 5 years ago

Ah thanks! I thought it compiles every night via cron or something because of its name.

rossanag commented 5 years ago

@rossanag Thank you for checking. It seems latest nightly is not ready yet, I will send you ping again.

Edit: Please check "advanced options" checkbox. Then you can select and deselect platforms.

About the default platform issue, I will take a look.

You are right, my bad, after checking "Advanced options" I could select another platform except the option for VSCode. I think getting the list box enabled by default would be more comfortable.

I can select VSCode platform just from the command line. I think I followed all the steps for get it included into the frontend.

hiroMTB commented 5 years ago

Thanks! I also noticed that default platform is set properly if we download PG from nightly or official zip. OSX is set as default for all OS but only for development environment (compile from source code).

On Sun, Oct 20, 2019, 8:39 AM rossanag notifications@github.com wrote:

@rossanag https://github.com/rossanag Thank you for checking. It seems latest nightly is not ready yet, I will send you ping again.

Edit: Please check "advanced options" checkbox. Then you can select and deselect platforms.

About the default platform issue, I will take a look.

You are right, my bad, after checing "Advanced options" I could select another platform except the option for VSCode. I think getting it enabled by default would be more comfortable.

I can select VSCode platform from the command line. I think I followed all the steps for get it included into the frontend.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/openframeworks/projectGenerator/issues/218?email_source=notifications&email_token=AABPGACLTY5EP536Z27XMTTQPOLDNA5CNFSM4JAEXMWKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBX63DY#issuecomment-544206223, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABPGADW74J6PWGZRXKAR4TQPOLDNANCNFSM4JAEXMWA .

ofTheo commented 5 years ago

@hiroMTB @rossanag maybe you could check the the nightly when it builds tonight? We're hoping to do a Release soon so would be good to make sure the PG is working with your changes.

Note: nightlies were broken again but I think should be good tonight - needed node to be updated to match the shrinkwrap.js update.

Thanks! Theo

rossanag commented 5 years ago

@ofTheo I will check it briefly, maybe later on. Best!

rossanag commented 4 years ago

Hello I was trying PG, it works fine in t he GUI and command line version, in the sense it creates the project file according the template selected (qtCreator, vscode, etc). After creating the project with the GUI if I select the option to open the IDE afterwards, it just opens the .qbs file no matter which template I have choosen. Anyway the project file can be open inside the proper IDE or by double clicking the project file created into myApps/app folder, and then the IDE opens correctly. Despite I create a vscode project, a .qbs file project is also created by default.

The popup windows with errors have disappeared.

Ubuntu 19.10 64 bits oF 10.01 - nighybuild 20191022 gcc6

hiroMTB commented 4 years ago

Thanks! I also tested under following platforms and can confirm js error disappeared.

@rossanag Thank you for your catch. This is a bit difficult situation right now. For example, when the user selects Xcode and vscode at the same time, we can not decide which IDE to open. The fundamental reason for this is that we use template feature to support vscode. Originally I wanted to put vscode option in the platform dropdown list. However, we noticed vscode does not specify any platform because it supports all platform. Right now the platform dropdown is made of mix of "OS" and "IDE". Probably we need to separate it to make thing clear.

ofTheo commented 4 years ago

Thanks @rossanag @hiroMTB ! I'll close this issue as it seems mostly solved. We can always open a new one for the 'Open in IDE' issue which is less urgent.

Sounds like the Project Generator might be good to go for the next OF release.