macOS issue with addons in v67

[dimitre]

I'm testing v67 here by going to examples/templates/allAddonsExample when I run PG here

../../../apps/pgd/commandLine/bin/projectGenerator.app/Contents/MacOS/projectGenerator -o../../.. . 
[notice ] { "openFrameworks projectGenerator": "67" }
[notice ] ofPath set and valid using ["/Volumes/tool/of"]

[notice ] -----------------------------------------------
[notice ] from -o option
[notice ] project path is: ["/Volumes/tool/of/examples/templates/allAddonsExample"]
[notice ] setting up new project "/Volumes/tool/of/examples/templates/allAddonsExample"
[notice ] project path is: ["/Volumes/tool/of/examples/templates/allAddonsExample"]

[notice ] create project "/Volumes/tool/of/examples/templates/allAddonsExample"
[notice ] templatePath: ["/Volumes/tool/of/scripts/templates/osx"]
[notice ] projectPath: ["/Volumes/tool/of/examples/templates/allAddonsExample"]
[notice ] saving addons.make
[notice ] project created! 
[notice ] -----------------------------------------------

1 project created [notice ] in 0.0189286 seconds

I see addons.make being emptied and xcode project is generated without any addons it is like PG doesn't find addons folder. cc @danoli3

[danoli3]

Put on verbose logging and try again. Where is Pg located in the oF dir or elsewhere? Is it in downloads

[dimitre]

pg is in of dir, equivalent depth to apps/projectGenerator/commandLine I'm invoking from the example dir and passing the default -o../../.. as always not in downloads

[dimitre]

now verbose I have to checkout again addons.make because it is emptied every time. Here I've used cat before and after invoking pg to show addons.make content (with addons, and without)

d@zen allAddonsExample % git checkout master -- addons.make                                                                    
d@zen allAddonsExample % cat addons.make
ofxAssimpModelLoader
ofxGui
ofxKinect
ofxNetwork
ofxOpenCv
ofxOsc
ofxSvg
ofxThreadedImageLoader
ofxXmlSettings
d@zen allAddonsExample % ../../../apps/pgd/commandLine/bin/projectGenerator.app/Contents/MacOS/projectGenerator -o../../.. -v .

[notice ] { "openFrameworks projectGenerator": "67" }
[notice ] ofPath set and valid using ["/Volumes/tool/of"]

[verbose]  projectPath path: ["/Volumes/tool/of/examples/templates/allAddonsExample"] root_path: ["/"]
[verbose]  ofPath path: ["/Volumes/tool/of"]
[verbose]  ofRoot path: ["/Volumes/tool/of"]
[verbose]  projectPath path: ["/Volumes/tool/of/examples/templates/allAddonsExample"]
[verbose]  The project path exists.
[verbose]   and it is a directory.
[notice ] -----------------------------------------------
[verbose] target platform is: [osx]
[verbose] setting OF path to: ["/Volumes/tool/of"]
[notice ] from -o option
[notice ] project path is: ["/Volumes/tool/of/examples/templates/allAddonsExample"]
[notice ] setting up new project "/Volumes/tool/of/examples/templates/allAddonsExample"
[notice ] project path is: ["/Volumes/tool/of/examples/templates/allAddonsExample"]

[notice ] create project "/Volumes/tool/of/examples/templates/allAddonsExample"
[notice ] templatePath: ["/Volumes/tool/of/scripts/templates/osx"]
[notice ] projectPath: ["/Volumes/tool/of/examples/templates/allAddonsExample"]
[verbose] xcodeProject: xattr set correctly for /bin

[verbose] Found source file: [/Volumes/tool/of/examples/templates/allAddonsExample/src/ofApp.cpp]
[verbose] [prjFiles-addIncludeDir] contains src - Adding dir: [src]
[notice ] saving addons.make
[notice ] project created! 
[notice ] -----------------------------------------------

1 project created [notice ] in 0.0214793 seconds

[notice ] { "status": "EXIT_OK" }
d@zen allAddonsExample % cat addons.make
d@zen allAddonsExample % 

[danoli3]

This has happened to me in the past a while ago when testing passing command line to build directory version. Source reset on file in git

It has to be some sort of -o issue and then can’t find addons once when passing via command line. The tests in the script folders should cover all the cases see which one is yours and add a test case

Scripts/osx/test

I think first solution should be fixing the damn addons.mk getting cleared with ability to handle #ofxAddonDisabled

Like:

ofxAssimpModelLoader ofxGui

ofxXml

Also when it can’t find any addons it should cancel rather than continue, it’s obviously in error state then

This is definitely -o issue

On Thu, 8 Aug 2024 at 1:03 AM, Dimitre @.***> wrote:

now verbose I have to checkout again addons.make because it is emptied every time. I've used cat before and after invoking pg to show addons.make content

@. allAddonsExample % git checkout master -- addons.make @. allAddonsExample % cat addons.make ofxAssimpModelLoader ofxGui ofxKinect ofxNetwork ofxOpenCv ofxOsc ofxSvg ofxThreadedImageLoader ofxXmlSettings @.*** allAddonsExample % ../../../apps/pgd/commandLine/bin/projectGenerator.app/Contents/MacOS/projectGenerator -o../../.. -v .

[notice ] { "openFrameworks projectGenerator": "67" } [notice ] ofPath set and valid using ["/Volumes/tool/of"]

[verbose] projectPath path: ["/Volumes/tool/of/examples/templates/allAddonsExample"] root_path: ["/"] [verbose] ofPath path: ["/Volumes/tool/of"] [verbose] ofRoot path: ["/Volumes/tool/of"] [verbose] projectPath path: ["/Volumes/tool/of/examples/templates/allAddonsExample"] [verbose] The project path exists. [verbose] and it is a directory. [notice ] ----------------------------------------------- [verbose] target platform is: [osx] [verbose] setting OF path to: ["/Volumes/tool/of"] [notice ] from -o option [notice ] project path is: ["/Volumes/tool/of/examples/templates/allAddonsExample"] [notice ] setting up new project "/Volumes/tool/of/examples/templates/allAddonsExample" [notice ] project path is: ["/Volumes/tool/of/examples/templates/allAddonsExample"]

[notice ] create project "/Volumes/tool/of/examples/templates/allAddonsExample" [notice ] templatePath: ["/Volumes/tool/of/scripts/templates/osx"] [notice ] projectPath: ["/Volumes/tool/of/examples/templates/allAddonsExample"] [verbose] xcodeProject: xattr set correctly for /bin

[verbose] Found source file: [/Volumes/tool/of/examples/templates/allAddonsExample/src/ofApp.cpp] [verbose] [prjFiles-addIncludeDir] contains src - Adding dir: [src] [notice ] saving addons.make [notice ] project created! [notice ] -----------------------------------------------

1 project created [notice ] in 0.0214793 seconds

[notice ] { "status": "EXIT_OK" } @. allAddonsExample % cat addons.make @. allAddonsExample %

— Reply to this email directly, view it on GitHub https://github.com/openframeworks/projectGenerator/issues/563#issuecomment-2273690280, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAGK2HC6VUMPGOUEHKYNIA3ZQIZLFAVCNFSM6AAAAABMEODGG6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENZTGY4TAMRYGA . You are receiving this because you were mentioned.Message ID: @.***>

[dimitre]

Ok I've noticed this happens if you don't pass addons by parameter and rely in addons.make to build your project so it will be calling a specific part of the code, and no baseProject::parseAddons was ever called. I've proposed a PR but probably it is missing from other places in PG code

[danoli3]

That makes sense as the pG is always sending that, okay let’s add that as a test case

On Thu, 8 Aug 2024 at 8:17 AM, Dimitre @.***> wrote:

Ok I've noticed this happens if you don't pass addons by parameter and rely in addons.make to build your project so it will be calling a specific part of the code, and no baseProject::parseAddons was ever called. I've proposed a PR but probably it is missing from other places in PG code

— Reply to this email directly, view it on GitHub https://github.com/openframeworks/projectGenerator/issues/563#issuecomment-2274442111, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAGK2HGNMODREUFB7L3FF4LZQKMGHAVCNFSM6AAAAABMEODGG6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENZUGQ2DEMJRGE . You are receiving this because you were mentioned.Message ID: @.***>

[danoli3]

@dimitre fixed yeah?

[dimitre]

closed by https://github.com/openframeworks/projectGenerator/pull/564