search

openfrontier / docker-gerrit

Build a Docker image with the Gerrit code review system
Apache License 2.0
196 stars 118 forks source link

override default start action with $GERRIT_START_ACTION #47

Closed crorvick closed 7 years ago

crorvick commented 7 years ago

Starting Gerrit with 'daemon' causes log messages to be sent to the console instead of $GERRIT_SITE/logs/error_log. Start Gerrit with 'supervise' instead so that log messages are persisted while allowing the user to change this default with GERRIT_START_ACTION.

thinkernel commented 7 years ago

Hi there. I agree that provide an option like GERRIT_START_ACTION is a good idea because you never know how people want to start their Gerrit. The only thing you might pay a attention is that if docker stop/restart command can work properly in the supervise mode. But I'm still not quit sure that we should change the default start mode from the daemon/run to the supervise. The log messages are sent to the console because people may like to utilize docker logs to watch the log messages. And people may also want to aggregate docker logs by switching the logging driver to something like Journald logging driver. So would you mind to keep the daemon as the default mode? And I would be very happy if you can add some instructions into the README.md about how to utilize the GERRIT_START_ACTION in order to let other guys know the new feature.

crorvick commented 7 years ago

Sure, sounds good. I'll send you an update sometime in the next day or two. I wasn't actually aware of docker logs so I'll take a look at that as well.

Thanks!

Chris

On Feb 16, 2017 00:34, "thinkernel" notifications@github.com wrote:

Hi there. I agree that provide an option like GERRIT_START_ACTION is a good idea because you never know how people want to start their Gerrit. The only thing you might pay a attention is that if docker stop/restart command can work properly in the supervise mode. But I'm still not quit sure that we should change the default start mode from the daemon/run to the supervise. The log messages are sent to the console because people may like to utilize docker logs to watch the log messages. And people may also want to aggregate docker logs by switching the logging driver to something like Journald logging driver https://docs.docker.com/engine/admin/logging/journald/. So would you mind to keep the daemon as the default mode? And I would be very happy if you can add some instructions into the README.md about how to utilize the GERRIT_START_ACTION in order to let other guys know the new feature.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/openfrontier/docker-gerrit/pull/47#issuecomment-280244272, or mute the thread https://github.com/notifications/unsubscribe-auth/AAyVlj5xsC0yI_rxgqrB13WwGz1X7QpHks5rc-3vgaJpZM4MCOrm .

thinkernel commented 7 years ago

Great works!