search

openfrontier / docker-gerrit

Build a Docker image with the Gerrit code review system
Apache License 2.0
196 stars 118 forks source link

Remove useless curly brackets #48

Closed joan38 closed 6 years ago

joan38 commented 7 years ago

I think the other commit will disappear once the we merge https://github.com/openfrontier/docker-gerrit/pull/44 and I rebase

joan38 commented 7 years ago

@thinkernel Rebased

thinkernel commented 7 years ago

Hi @joan38 Here's some reference about when {} is necessary. String substitution is kind of tricky. For me, curly brackets is a kind of safety insurance. http://unix.stackexchange.com/questions/4899/var-vs-var-and-to-quote-or-not-to-quote http://stackoverflow.com/questions/8748831/when-do-we-need-curly-braces-in-variables-using-bash http://pubs.opengroup.org/onlinepubs/9699919799/utilities/V3_chap02.html#tag_18_06_02