openfrontier / docker-gerrit

Build a Docker image with the Gerrit code review system
Apache License 2.0
197 stars 116 forks source link

[Question] hostname resolution in notification mail #58

Closed fleimgruber closed 7 years ago

fleimgruber commented 7 years ago

I am running with the following command

docker run -v ~/volumes/gerrit:/var/gerrit/review_site --name gerrit_email -p 8090:8080 -p 29418:29418
-e AUTH_TYPE=LDAP
-e LDAP_SERVER=ldap://xxx.xxx.xxx.xxx
-e LDAP_ACCOUNTBASE="ou=Users,dc=D01,dc=ARC,dc=LOCAL"
-e LDAP_ACCOUNTPATTERN='(&(objectClass=person)(sAMAccountName=${username}))'
-e LDAP_ACCOUNTSCOPE="sub"
-e AUTH_GIT_BASIC_AUTH=true
-e SMTP_SERVER="xxx.xxx.xxx.xxx"
-e SMTP_SERVER_PORT="25"
-e SMTP_FROM="gerrit.hostname"
-d openfrontier/gerrit

notification mail is sent, but contains links of the form

http://7c65fe1e75a4:8080/7

which won't work.

Is there a recommended approach for this, short of modifying the email templates with hardcoded host:port information?

fleimgruber commented 7 years ago

Sorry for the noise, should have looked more carefully into code and docs, this is achieved by the WEBURL env var.