search

openfrontier / docker-gerrit

Build a Docker image with the Gerrit code review system
Apache License 2.0
196 stars 118 forks source link

upgrade to gerrit 2.14 #62

Closed rburgst closed 7 years ago

rburgst commented 7 years ago

fixes #61

thinkernel commented 7 years ago

Hi Rainer. I'm sorry but could you please revert to your last commit? I think the only thing that need to to is to remove those re-index all lines.

rburgst commented 7 years ago

of course I could do that however, I currently dont see how this would work. At least for my setup the server didn't boot due to the missing migration. How do you suggest to turn on online indexing and do you know whether this will work, then?

thinkernel commented 7 years ago

@rburgst Thanks for the information. It was supposed to work, automatically. Anyway, I'm working on it. Give me some time, please.

thinkernel commented 7 years ago

Hi @rburgst I've already encounter the same issue here.

[2017-06-06 11:06:49,024] [main] ERROR com.google.gerrit.pgm.Daemon : Unable to start daemon gerrit_1 | com.google.inject.ProvisionException: Unable to provision, see the following errors: gerrit_1 | gerrit_1 | 1) No index versions ready; run java -jar /var/gerrit/review_site/bin/gerrit.war reindex gerrit_1 | gerrit_1 | 1 error gerrit_1 | at com.google.gerrit.server.index.AbstractVersionManager.initIndex(AbstractVersionManager.java:145) gerrit_1 | at com.google.gerrit.server.index.AbstractVersionManager.start(AbstractVersionManager.java:76) gerrit_1 | at com.google.gerrit.lifecycle.LifecycleManager.start(LifecycleManager.java:92) gerrit_1 | at com.google.gerrit.pgm.Daemon.start(Daemon.java:321) gerrit_1 | at com.google.gerrit.pgm.Daemon.run(Daemon.java:230) gerrit_1 | at com.google.gerrit.pgm.util.AbstractProgram.main(AbstractProgram.java:61) gerrit_1 | at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) gerrit_1 | at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) gerrit_1 | at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) gerrit_1 | at java.lang.reflect.Method.invoke(Method.java:498) gerrit_1 | at com.google.gerrit.launcher.GerritLauncher.invokeProgram(GerritLauncher.java:204) gerrit_1 | at com.google.gerrit.launcher.GerritLauncher.mainImpl(GerritLauncher.java:108) gerrit_1 | at com.google.gerrit.launcher.GerritLauncher.main(GerritLauncher.java:63) gerrit_1 | at Main.main(Main.java:24) gerrit_1 | [2017-06-06 11:06:49,025] [Reindex v32-v39] INFO com.google.gerrit.server.index.OnlineReindexer : Starting online reindex from schema version 32 to 39

In the daemon mode there's no way let online reindex kick in before daemon exit itself. So let's go back to your second commit.

rburgst commented 7 years ago

is there anything that I should still change in commmit 2?

thinkernel commented 7 years ago

I'm doing the test. It will be merged to master soon.

thinkernel commented 7 years ago

2.14 is released. Try it and let me know if everything is good here, please.