search

openfrontier / docker-gerrit

Build a Docker image with the Gerrit code review system
Apache License 2.0
196 stars 118 forks source link

link environment variables are superseded #64

Closed terinjokes closed 5 years ago

terinjokes commented 7 years ago

In our environment, which uses version 2 of the docker composer format, docker no longer sets the superseded link environment variables. Unfortunately, if using a database other than H2, this project assumes the link environment variables are set.

While I can set the link environment variables in the docker-compose file, it would be great if they had more descriptive names than DB_PORT_5432_TCP_ADDR 😉

thinkernel commented 7 years ago

This project might be an example for your question.

terinjokes commented 7 years ago

@thinkernel: yep, that's exactly what I did internally.

Again, not difficult once you take a peak at the entrypoint, but also not something that's magic anymore.

thinkernel commented 7 years ago

In the case of using compose, that's true. But --link still works with docker run command. So it might not be the best time for us to change the name of that environment variable.

thinkernel commented 5 years ago

External database options are supported in #93. So I think this can be closed.