search

openfun / cunningham

🎨 The Open FUN Design System
https://openfun.github.io/cunningham/
MIT License
23 stars 2 forks source link

⬆️(deps) upgrade to Storybook v8 #304

Closed NathanVss closed 7 months ago

NathanVss commented 7 months ago

⚠️ For reviewers: please take a bit of your time to walk through the Storybook to make sure everything is fine on your side too. There are tons of stories, I did my best to be most conscientious as possible, but across nearly 300 stories I could be tricky. 🙏🙏🙏

sb8
changeset-bot[bot] commented 7 months ago

⚠️ No Changeset found

Latest commit: 392bcdcc6abdca18597a4f0ca9686ef0eaa0570f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

levrik commented 7 months ago

I guess my comments got lost inside a resolved conversation, so posting the link here just for visibility: https://github.com/openfun/cunningham/pull/304#discussion_r1533430237

NathanVss commented 6 months ago

I guess my comments got lost inside a resolved conversation, so posting the link here just for visibility: #304 (comment)

Oh sorry I missed your comments 😅 Huge thank you it works, that was really nice of you 🙏