Group components - Githubissues

openfun / jitsi-magnify

An authentication and room management system for Jitsi built with Django/React

MIT License

23 stars 6 forks source link

Group components #16

Closed Leonils closed 2 years ago

Leonils commented 2 years ago

Purpose

Add components to present a selectable list of groups. Actions are not implemented yet. The components are responsive.

Proposal

3 components added:

A single group row: GroupRow
A header to select/unselect several rows GroupsHeader
The list itself, including the 2 previous components GroupsList

Remark : this is the continuation of the PR #12, for which the branch was too much different from main after the refactoring from #8

sampaccoud commented 2 years ago

I have 2 general comments:

now that we added ReactIntl, shouldn't we translate all our strings?
using factories in your tests would be more powerful than mocks? See here for example: https://github.com/openfun/richie/blob/master/src/frontend/js/utils/test/factories.ts

Leonils commented 2 years ago

For the factories, it may be useful, but maybe it can come along with the mocking of the requests to the api ( see #19 ). Another concern is that the reference lib to do that in js has been violently discontinued by it's creator (faker), and the example you mentioned has this one as a dependency. Should we use it anyway ? Has anyone an alternative ?

asynkr commented 2 years ago

the reference lib to do that in js has been violently discontinued by it's creator (faker)

It seems that Faker has found new maintainers, but I don't know if this is the version used in factories. Github : https://github.com/faker-js/faker Announcement : https://fakerjs.dev/about/announcements/2022-01-14.html