search

openfun / jitsi-magnify

An authentication and room management system for Jitsi built with Django/React
MIT License
23 stars 6 forks source link

:lipstick: (apps:frontend) improve scroll behaviour of SimpleLayout #178

Closed SofienM closed 1 year ago

SofienM commented 1 year ago

Purpose

The overflow: scroll property was initially added to the SimpleLayout component to handle the case when its height exceeds 100vh. This commit changes it to auto so that the scrollbar appears only when needed.

Before: Useless scrolls: image

Only Y scroll useful: image

Now image image

sampaccoud commented 1 year ago

@SofienM Can you fix the linting errors and we'll merge it!

SofienM commented 1 year ago

@sampaccoud Didn't see the failing checks, it's fixed now !